Avii/Radicale
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

UI: Bugfix showing sharing permissions

Browse Source
This commit is contained in:
Max Berger
2026-04-22 20:59:06 +02:00
parent 7d07962592
commit ecac9c6ced
2 changed files with 27 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
integ_tests/test_sharing.py
View File

@@ -63,6 +63,16 @@ def test_create_and_delete_share_by_key(
"tr[data-name='sharetokenrowtemplate']:not(.hidden) span[data-name='ro']" "tr[data-name='sharetokenrowtemplate']:not(.hidden) span[data-name='ro']"
) )
).to_be_visible() ).to_be_visible()
expect(
page.locator(
"tr[data-name='sharetokenrowtemplate']:not(.hidden) span[data-name='rw']"
)
).to_be_hidden()
expect(
page.locator(
"tr[data-name='sharetokenrowtemplate']:not(.hidden) span[data-name='conversion']"
)
).to_be_hidden()
page.click('tr:not(.hidden) button[data-name="delete"]', strict=True) page.click('tr:not(.hidden) button[data-name="delete"]', strict=True)
page.click('#deleteconfirmationscene button[data-name="delete"]') page.click('#deleteconfirmationscene button[data-name="delete"]')
expect( expect(
@@ -79,6 +89,16 @@ def test_create_and_delete_share_by_key(
"tr[data-name='sharetokenrowtemplate']:not(.hidden) span[data-name='rw']" "tr[data-name='sharetokenrowtemplate']:not(.hidden) span[data-name='rw']"
) )
).to_be_visible() ).to_be_visible()
expect(
page.locator(
"tr[data-name='sharetokenrowtemplate']:not(.hidden) span[data-name='ro']"
)
).to_be_hidden()
expect(
page.locator(
"tr[data-name='sharetokenrowtemplate']:not(.hidden) span[data-name='conversion']"
)
).to_be_hidden()
page.click('tr:not(.hidden) button[data-name="delete"]', strict=True) page.click('tr:not(.hidden) button[data-name="delete"]', strict=True)
page.click('#deleteconfirmationscene button[data-name="delete"]') page.click('#deleteconfirmationscene button[data-name="delete"]')
expect( expect(
@@ -388,6 +408,11 @@ def test_create_and_delete_share_by_bday(
"tr[data-name='sharemaprowtemplate']:not(.hidden) span[data-name='ro']" "tr[data-name='sharemaprowtemplate']:not(.hidden) span[data-name='ro']"
) )
).to_be_hidden() ).to_be_hidden()
expect(
page.locator(
"tr[data-name='sharemaprowtemplate']:not(.hidden) span[data-name='rw']"
)
).to_be_hidden()
# Instead, there should be the conversion icon # Instead, there should be the conversion icon
expect( expect(

6
radicale/web/internal_data/js/utils/permissions.js
View File

@@ -35,18 +35,16 @@ export function displayPermissionsOrConversion(conversion, permissions, node) {
rwElement.classList.add("hidden"); rwElement.classList.add("hidden");
} else { } else {
permissions = (permissions || "").toLowerCase(); permissions = (permissions || "").toLowerCase();
if (permissions === "rw") { if (permissions.includes('w')) {
rwElement.classList.remove("hidden"); rwElement.classList.remove("hidden");
rwElement.setAttribute("title", "Read and write"); rwElement.setAttribute("title", "Read and write");
roElement.classList.add("hidden"); roElement.classList.add("hidden");
conversionElement.classList.add("hidden"); conversionElement.classList.add("hidden");
} else if (permissions === "r") { } else {
roElement.classList.remove("hidden"); roElement.classList.remove("hidden");
roElement.setAttribute("title", "Read-only"); roElement.setAttribute("title", "Read-only");
rwElement.classList.add("hidden"); rwElement.classList.add("hidden");
conversionElement.classList.add("hidden"); conversionElement.classList.add("hidden");
} else {
console.warn("Unknown permissions", permissions);
} }
} }
} }