Avii/Radicale
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

UI: disable conversion mode buttons on edit

Browse Source 
The conversion type cannot be changed once a share is created, so disable the edit buttons.
This commit is contained in:
Max Berger
2026-06-13 21:13:45 +02:00
parent 04cbf35a23
commit ea8f4a4477
2 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
integ_tests/test_sharing.py
View File

@@ -423,6 +423,16 @@ def test_create_and_delete_share_by_bday(
) )
).to_have_count(1) ).to_have_count(1)
# Edit the bday share to verify that the conversion selection is disabled in the loaded state
page.click(
"tr[data-name='sharemaprowtemplate']:not(.hidden) button[data-name='edit']",
strict=True,
)
expect(page.locator("#createeditsharescene h1")).to_have_text("Edit Share")
expect(page.locator("input#newshare_conv_none")).to_be_disabled()
expect(page.locator("input#newshare_conv_bday")).to_be_disabled()
page.click('#createeditsharescene button[data-name="cancel"]')
# Close the share scene and verify the virtual bday calendar is now in the collections list # Close the share scene and verify the virtual bday calendar is now in the collections list
page.click('#sharecollectionscene button[data-name="cancel"]') page.click('#sharecollectionscene button[data-name="cancel"]')
expect(page.locator("#sharecollectionscene")).to_be_hidden() expect(page.locator("#sharecollectionscene")).to_be_hidden()

1
radicale/web/internal_data/js/scenes/CreateEditShareScene.js
View File

@@ -427,6 +427,7 @@ export class CreateEditShareScene {
radio.value = opt; radio.value = opt;
radio.id = id; radio.id = id;
radio.checked = (opt === initial_conversion); radio.checked = (opt === initial_conversion);
radio.disabled = this._edit;
radio.onchange = () => this._on_conversion_change(); radio.onchange = () => this._on_conversion_change();
let label = document.createElement("label"); let label = document.createElement("label");