Avii/Radicale
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Encode password to allow special characters

Browse Source 
XMLHttpRequest.open() does not automatically encode the password. Though it builds an basic auth schemed URI where '%' is the escaping indicator, thus passwords containing this characters are not accepted this way without manually replacing '%' with '%25' on the form.
This commit is contained in:
Tobias Stettner
2021-01-08 10:40:37 +01:00
committed by Peter Bieringer
parent 08a4c792b1
commit 8fc5352e27
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
radicale/web/internal_data/fn.js
View File

@@ -124,7 +124,7 @@ function Collection(href, type, displayname, description, color, source) {
*/ */
function get_principal(user, password, callback) { function get_principal(user, password, callback) {
let request = new XMLHttpRequest(); let request = new XMLHttpRequest();
request.open("PROPFIND", SERVER + ROOT_PATH, true, user, password); request.open("PROPFIND", SERVER + ROOT_PATH, true, user, encodeURIComponent(password));
request.onreadystatechange = function() { request.onreadystatechange = function() {
if (request.readyState !== 4) { if (request.readyState !== 4) {
return; return;
@@ -167,7 +167,7 @@ function get_principal(user, password, callback) {
*/ */
function get_collections(user, password, collection, callback) { function get_collections(user, password, collection, callback) {
let request = new XMLHttpRequest(); let request = new XMLHttpRequest();
request.open("PROPFIND", SERVER + collection.href, true, user, password); request.open("PROPFIND", SERVER + collection.href, true, user, encodeURIComponent(password));
request.setRequestHeader("depth", "1"); request.setRequestHeader("depth", "1");
request.onreadystatechange = function() { request.onreadystatechange = function() {
if (request.readyState !== 4) { if (request.readyState !== 4) {
@@ -280,7 +280,7 @@ function get_collections(user, password, collection, callback) {
*/ */
function upload_collection(user, password, collection_href, file, callback) { function upload_collection(user, password, collection_href, file, callback) {
let request = new XMLHttpRequest(); let request = new XMLHttpRequest();
request.open("PUT", SERVER + collection_href, true, user, password); request.open("PUT", SERVER + collection_href, true, user, encodeURIComponent(password));
request.onreadystatechange = function() { request.onreadystatechange = function() {
if (request.readyState !== 4) { if (request.readyState !== 4) {
return; return;
@@ -305,7 +305,7 @@ function upload_collection(user, password, collection_href, file, callback) {
*/ */
function delete_collection(user, password, collection, callback) { function delete_collection(user, password, collection, callback) {
let request = new XMLHttpRequest(); let request = new XMLHttpRequest();
request.open("DELETE", SERVER + collection.href, true, user, password); request.open("DELETE", SERVER + collection.href, true, user, encodeURIComponent(password));
request.onreadystatechange = function() { request.onreadystatechange = function() {
if (request.readyState !== 4) { if (request.readyState !== 4) {
return; return;
@@ -330,7 +330,7 @@ function delete_collection(user, password, collection, callback) {
*/ */
function create_edit_collection(user, password, collection, create, callback) { function create_edit_collection(user, password, collection, create, callback) {
let request = new XMLHttpRequest(); let request = new XMLHttpRequest();
request.open(create ? "MKCOL" : "PROPPATCH", SERVER + collection.href, true, user, password); request.open(create ? "MKCOL" : "PROPPATCH", SERVER + collection.href, true, user, encodeURIComponent(password));
request.onreadystatechange = function() { request.onreadystatechange = function() {
if (request.readyState !== 4) { if (request.readyState !== 4) {
return; return;